Opened 10 years ago

Closed 10 years ago

#68 closed defect (fixed)

Incorrect layer indeces in assert statements

Reported by: hallapur Owned by: Vadim
Priority: minor Milestone: SHM-8.0
Component: SHM software Version: SHM-7.0
Keywords: Cc: Vadim, jct-vc@…

Description

These asserts in TDecCAVLC.cpp have wrong layer indeces:

assert(rps->getNumberOfNegativePictures() <= rpcSlice->getVPS()->getMaxVpsDecPicBufferingMinus1(ii , rpcSlice->getLayerId() , rpcSlice->getVPS()->getMaxSLayersInLayerSetMinus1(ii)));
assert(rps->getNumberOfPositivePictures() <= rpcSlice->getVPS()->getMaxVpsDecPicBufferingMinus1(ii , rpcSlice->getLayerId() , rpcSlice->getVPS()->getMaxSLayersInLayerSetMinus1(ii)) - rps->getNumberOfNegativePictures());
assert((rps->getNumberOfPositivePictures() + rps->getNumberOfNegativePictures() + rps->getNumberOfLongtermPictures()) <= rpcSlice->getVPS()->getMaxVpsDecPicBufferingMinus1(ii , rpcSlice->getLayerId() , rpcSlice->getVPS()->getMaxSLayersInLayerSetMinus1(ii)));

rpcSlice->getLayerId() should be replaced with
rpcSlice->getVPS()->getLayerIdInVps(rpcSlice->getLayerId())

A patch to correct the issue is attached.

Attachments (1)

TDecCAVLC.cpp.patch​ (1.8 KB) - added by hallapur 10 years ago.

Download all attachments as: .zip

Change history (3)

comment:1 Changed 10 years ago by DefaultCC Plugin

  • Cc Vadim jct-vc@… added

Changed 10 years ago by hallapur

comment:2 Changed 10 years ago by Vadim

  • Resolution set to fixed
  • Status changed from new to closed

fixed with rev 1043

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Gerhard Tech(Always)
  • hallapur(Reporter)
  • jct-vc@…(Subscriber)
  • Karsten Suehring(Always)
  • Vadim Seregin(Owner, Subscriber, Participant)