Opened 10 years ago

Closed 10 years ago

#58 closed defect (fixed)

rev 1005: Void TDecTop::xDeriveSmallestLayerId(TComVPS* vps)

Reported by: jaypadia Owned by: Vadim
Priority: minor Milestone: SHM-8.0
Component: SHM software Version:
Keywords: Cc: Vadim, jct-vc@…

Description

rev 1005 - non HEVC base layer changes adds the following code

File: TDecTop.cpp, line: 2671, function: Bool TDecTop::decode()

#if R0235_SMALLEST_LAYER_ID
      xDeriveSmallestLayerId(m_parameterSetManagerDecoder.getPrefetchedVPS(0));
#endif

This function uses Target OLS, which may not be set
example: TAppDecoder.exe -b <bs_name> -ls <num_layers_to_decode>

Void TDecTop::xDeriveSmallestLayerId(TComVPS* vps)
{
  UInt smallestLayerId;
  UInt targetOlsIdx = getCommonDecoderParams()->getTargetOutputLayerSetIdx();

I believe the function should be able to handle if Target OLS = -1. Currently it crashes in that scenario.
Set the 'SmallestLayerId = 0' in that case?

Attachments (1)

FixTargetOlsIdx.patch​ (2.6 KB) - added by fhendry 10 years ago.

Download all attachments as: .zip

Change history (4)

comment:1 Changed 10 years ago by DefaultCC Plugin

  • Cc Vadim jct-vc@… added

Changed 10 years ago by fhendry

comment:2 in reply to: ↑ description Changed 10 years ago by fhendry

When Target OLS = -1 there is already function that derive a value to make it not -1. However, it was not called appropriately after some modification made earlier.

The attached patch provides fix for this

Replying to jaypadia:

rev 1005 - non HEVC base layer changes adds the following code

File: TDecTop.cpp, line: 2671, function: Bool TDecTop::decode()

#if R0235_SMALLEST_LAYER_ID
      xDeriveSmallestLayerId(m_parameterSetManagerDecoder.getPrefetchedVPS(0));
#endif

This function uses Target OLS, which may not be set
example: TAppDecoder.exe -b <bs_name> -ls <num_layers_to_decode>

Void TDecTop::xDeriveSmallestLayerId(TComVPS* vps)
{
  UInt smallestLayerId;
  UInt targetOlsIdx = getCommonDecoderParams()->getTargetOutputLayerSetIdx();

I believe the function should be able to handle if Target OLS = -1. Currently it crashes in that scenario.
Set the 'SmallestLayerId = 0' in that case?

comment:3 Changed 10 years ago by Vadim

  • Resolution set to fixed
  • Status changed from new to closed

Fixed as suggested in the patch with rev 1007. Please reopen the ticket if the problem still exists.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Gerhard Tech(Always)
  • Hendry(Participant)
  • Jay Padia(Reporter)
  • jct-vc@…(Subscriber)
  • Karsten Suehring(Always)
  • Vadim Seregin(Owner, Subscriber, Participant)