Opened 9 years ago

Closed 9 years ago

#54 closed defect (fixed)

Use of sps_rep_format_idx

Reported by: jaypadia Owned by: Vadim
Priority: minor Milestone: SHM-8.0
Component: SHM software Version:
Keywords: Cc: Vadim, jct-vc@…

Description

To correctly use the SPS repformat when the sps_rep_format_idx is present, the way RepFormat value is passed needs to be fixed.

vps->getVpsRepFormat( vps->getVpsRepFormatIdx(sps->getUpdateRepFormatFlag() ? sps->getUpdateRepFormatIndex() : layerId) )

should be changed to (patch has the fix)

vps->getVpsRepFormat(sps->getUpdateRepFormatFlag() ? sps->getUpdateRepFormatIndex() : vps->getVpsRepFormatIdx(layerId))

Ref:
RepFormat* getVpsRepFormat(Int idx) { return &m_vpsRepFormat[idx]; } --- Takes RefFormatIdx as the input
This value is selected based on
The variable repFormatIdx is derived as follows (spec):
– If update_rep_format_flag is equal to 0, the variable repFormatIdx is set equal to vps_rep_format_idx[ LayerIdxInVps[ layerIdCurr ] ].
– Otherwise (update_rep_format_flag is equal to 1), repFormatIdx is set equal to sps_rep_format_idx.

Attachments (1)

SPSRepFormatIdxFix_jpadia_vidyo_150121.patch​ (5.8 KB) - added by jaypadia 9 years ago.

Download all attachments as: .zip

Change history (3)

comment:1 Changed 9 years ago by DefaultCC Plugin

  • Cc Vadim jct-vc@… added

Changed 9 years ago by jaypadia

comment:2 Changed 9 years ago by Vadim

  • Resolution set to fixed
  • Status changed from new to closed

patch was committed with rev 995

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Gerhard Tech(Always)
  • Jay Padia(Reporter)
  • jct-vc@…(Subscriber)
  • Karsten Suehring(Always)
  • Vadim Seregin(Owner, Subscriber, Participant)