Custom query (105 matches)

Filters
 
or
 
  
 
Columns

Show under each result:


Results (49 - 51 of 105)

Ticket Resolution Summary Owner Reporter
#58 fixed rev 1005: Void TDecTop::xDeriveSmallestLayerId(TComVPS* vps) Vadim jaypadia
Description

rev 1005 - non HEVC base layer changes adds the following code

File: TDecTop.cpp, line: 2671, function: Bool TDecTop::decode()

#if R0235_SMALLEST_LAYER_ID
      xDeriveSmallestLayerId(m_parameterSetManagerDecoder.getPrefetchedVPS(0));
#endif

This function uses Target OLS, which may not be set example: TAppDecoder.exe -b <bs_name> -ls <num_layers_to_decode>

Void TDecTop::xDeriveSmallestLayerId(TComVPS* vps)
{
  UInt smallestLayerId;
  UInt targetOlsIdx = getCommonDecoderParams()->getTargetOutputLayerSetIdx();

I believe the function should be able to handle if Target OLS = -1. Currently it crashes in that scenario. Set the 'SmallestLayerId = 0' in that case?

#57 fixed Setting the PTL in the init() function Vadim jaypadia
Description

Old way: PTL 0 is set using the PTL information from SPS. This is before the PTL changes.

Void TEncTop::init(Bool isFieldCoding)
{
  // initialize SPS
  xInitSPS();
  
  /* set the VPS profile information */
  *m_cVPS.getPTL() = *m_cSPS.getPTL();

After rev 941 (and rev 976) fix, the PTL changes are in. PTL_x is set using the config for PTL_idx x. Also, the new code below even takes care of PTL_0. So PTL_0 doesn't need to be set using the SPS; we would have SPS for the higher layers with different PTL values which could overwrite the PTL_0. Also the encoder config sets the PTL for VPS & SPS using the same configuration. So the line can be removed.

if MULTIPLE_PTL_SUPPORT
  //Populate PTL in VPS
  TComVPS *pVPS = m_acTEncTop[0].getVPS();
  for (int ii = 0; ii < m_numPTLInfo; ii++)
  {
    pVPS->getPTL(ii)->getGeneralPTL()->setLevelIdc(m_levelList[ii]);
    pVPS->getPTL(ii)->getGeneralPTL()->setTierFlag(m_levelTierList[ii]);
    pVPS->getPTL(ii)->getGeneralPTL()->setProfileIdc(m_profileList[ii]);
    pVPS->getPTL(ii)->getGeneralPTL()->setProfileCompatibilityFlag(m_profileCompatibility[ii], 1);
    pVPS->getPTL(ii)->getGeneralPTL()->setProgressiveSourceFlag(m_progressiveSourceFlagList[ii]);
    pVPS->getPTL(ii)->getGeneralPTL()->setInterlacedSourceFlag(m_interlacedSourceFlagList[ii]);
    pVPS->getPTL(ii)->getGeneralPTL()->setNonPackedConstraintFlag(m_nonPackedConstraintFlagList[ii]);
    pVPS->getPTL(ii)->getGeneralPTL()->setFrameOnlyConstraintFlag(m_frameOnlyConstraintFlagList[ii]);
  }

This line could be commented / removed.

  /* set the VPS profile information */
  //*m_cVPS.getPTL() = *m_cSPS.getPTL();
#56 fixed Assignment of value for base_layer_parameter_set_compatibility_flag[ i ] Vadim fhendry
Description

The code for assigning value for syntax element base_layer_parameter_set_compatibility_flag[ i ] is incorrect.

Currently the flag is set equal to 1 when SPSId and PPSId are equal to 0. However, according to the spec, we actually should check the layerId of the SPS and PPS used by pictures in the i-th layer and also need to check the reprepsentation format of the i-th layer.

Note: See TracQuery for help on using queries.