Opened 10 years ago

Last modified 10 years ago

#678 closed defect

Problem with Merging, Bug allows merging across slices for first row/column. — at Initial Version

Reported by: amitkchawla Owned by:
Priority: minor Milestone:
Component: HM Version: HM-7.2
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…


Problem in TEncSampleAdaptiveOffset::rdoSaoUnit() function,

The following code checks valid slice/tile for non first row and non first column, but i think that should not be case. If first line contains two slices, it will still try merge left and similarly vertically as well.

if (rx!=0)


check tile id and slice id

if ( (m_pcPic->getPicSym()->getTileIdxMap(addr-1) != m_pcPic->getPicSym()->getTileIdxMap(addr))
(m_pcPic->getCU(addr-1)->getSlice()->getSliceIdx() != m_pcPic->getCU(addr)->getSlice()->getSliceIdx()))


allowMergeLeft = 0;


if (ry!=0)

if ( (m_pcPic->getPicSym()->getTileIdxMap(addr-m_iNumCuInWidth) != m_pcPic->getPicSym()->getTileIdxMap(addr))
(m_pcPic->getCU(addr-m_iNumCuInWidth)->getSlice()->getSliceIdx() != m_pcPic->getCU(addr)->getSlice()->getSliceIdx()))


allowMergeUp = 0;



Change History (0)

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Amit(Reporter)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)