Opened 11 years ago

Last modified 9 years ago

#157 closed defect

FIXED_ROUNDING_FRAME_MEMORY modifies output picture rather than reference picture — at Version 2

Reported by: davidf Owned by: davidf
Priority: minor Milestone: HM-9.0
Component: HM Version: HM-3.0
Keywords: Cc: chujoh, fbossen, ksuehring, davidf, jct-vc@…

Description (last modified by davidf)

In TEncGOP.cpp:

      xCalculateAddPSNR( pcPic, pcPic->getPicYuvRec(), numBits, dEncTime );


xFixedRoundingPic() causes both the output picture and any reference picture to be modified.

xFixedRoundingPic() in the encoder should be performed after pcPic->getPicYuvRec()->copyToPic(pcPicYuvRecOut);. In the decoder, a similar change is required, however, the decoder does not currently have a separate reorder buffer.

Change History (2)

comment:1 Changed 11 years ago by fbossen

My understanding is that this should modify only the picture stored in the reference buffer.

comment:2 Changed 11 years ago by davidf

  • Description modified (diff)
  • Milestone changed from HM-3.1 to HM-3.2
  • Summary changed from FIXED_ROUNDING_FRAME_MEMORY modifies output picture after PSNR is calculated to FIXED_ROUNDING_FRAME_MEMORY modifies output picture rather than reference picture

Deferring until later. The fix for the encoder is trivial, however, the decoder fix isn't.

It should be noted that the reported data for the HM-3.0 software with FIXED_ROUNDING_FRAME_MEMORY enabled is correct, however, the output yuv files are not.

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Reporter, Owner, Subscriber, Participant)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Always)
  • Takeshi Chujoh(Subscriber)