Opened 13 years ago Last modified 11 years ago #157 closed defectFIXED_ROUNDING_FRAME_MEMORY modifies output picture rather than reference picture — at Version 2
Description (last modified by davidf)
In TEncGOP.cpp: xCalculateAddPSNR( pcPic, pcPic->getPicYuvRec(), numBits, dEncTime ); #if FIXED_ROUNDING_FRAME_MEMORY pcPic->getPicYuvRec()->xFixedRoundingPic(); #endif ... pcPic->getPicYuvRec()->copyToPic(pcPicYuvRecOut);
xFixedRoundingPic() causes both the output picture and any reference picture to be modified.
xFixedRoundingPic() in the encoder should be performed after pcPic->getPicYuvRec()->copyToPic(pcPicYuvRecOut);. In the decoder, a similar change is required, however, the decoder does not currently have a separate reorder buffer. Change History (2)comment:1 Changed 13 years ago by fbossencomment:2 Changed 13 years ago by davidf
Deferring until later. The fix for the encoder is trivial, however, the decoder fix isn't.
It should be noted that the reported data for the HM-3.0 software with FIXED_ROUNDING_FRAME_MEMORY enabled is correct, however, the output yuv files are not. Note: See
TracTickets for help on using
tickets. | This list contains all users that will be notified about changes made to this ticket. These roles will be notified: Reporter, Owner, Subscriber, Participant
|
My understanding is that this should modify only the picture stored in the reference buffer.