Changes between Initial Version and Version 1 of Ticket #1358, comment 6


Ignore:
Timestamp:
Jan 7, 2015, 3:34:21 PM (8 years ago)
Author:
ksuehring
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #1358, comment 6

    initial v1  
    11Based on the patches I understand what you mean.
    22
    3 Usually I prefer to have HLS names aligned to the code, especially the trace strings. But in this case the current code looks much more flexible with the intention of the first eight extension bits. The multi-layer extension (as seen in the syntax in R1013_v6) can easily added in another "case" statement. We need to support only the RExt extension in HM, but SHM and the MV/3D software can easily extend the structure here (maybe even SCC with another extension).
     3Usually I prefer to have HLS names aligned to the code, especially the trace strings. But in this case the current code looks much more flexible with the intention of the first eight extension bits. The multi-layer extension (as seen in the syntax in R1013_v6) can easily be added in another "case" statement. We need to support only the RExt extension in HM, but SHM and the MV/3D software can easily extend the structure here (maybe even SCC with another extension).
    44
    55I don't like the renaming of the array to pps_extension_Xbits, because it does not represent the standard text either. The only option that I would consider is to follow the syntax exactly and parse the already defined existence flags one by one and then the remainder. But with mentioned better flexibility, I would prefer to keep the code as is.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • David Flynn(Subscriber)
  • jct-vc@…(Subscriber)
  • Karl Sharman(Subscriber, Participant)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)
  • Nikolay Shlyakhov(Reporter, Participant)