Changeset 481 in 3DVCSoftware

Timestamp:

19 Jun 2013, 14:46:47 (11 years ago)

Author:

tech

Message:

Bug fixes related to not correctly initialized slice at encoder.

Location:

branches/HTM-DEV-0.3-dev2

Files:

• cfg/3D-HEVC/baseCfg_3view.cfg (modified) (1 diff)
• source/Lib/TLibCommon/TComDataCU.cpp (modified) (1 diff)
• source/Lib/TLibEncoder/TEncCavlc.cpp (modified) (2 diffs)
• source/Lib/TLibEncoder/TEncGOP.cpp (modified) (3 diffs)
• source/Lib/TLibEncoder/TEncSlice.cpp (modified) (2 diffs)
• source/Lib/TLibEncoder/TEncSlice.h (modified) (1 diff)

branches/HTM-DEV-0.3-dev2/cfg/3D-HEVC/baseCfg_3view.cfg

@@ -160 +160 @@
 
 #========== multiview coding tools ==========
-IvMvPred           : 1                                 # Inter-view motion prediction### DO NOT ADD ANYTHING BELOW THIS LINE ###
+IvMvPred           : 1                                 # Inter-view motion prediction
+### DO NOT ADD ANYTHING BELOW THIS LINE ###
 ### DO NOT DELETE THE EMPTY LINE BELOW ###

branches/HTM-DEV-0.3-dev2/source/Lib/TLibCommon/TComDataCU.cpp

@@ -2553 +2553 @@
 
   Int iPdmDir[2] = {0, 0};
-  getInterViewMergeCands(uiPUIdx, aiPdmRefIdx, acPdmMv, &cDisInfo, iPdmDir );
+  
+  if ( ivMvPredFlag )
+  {
+    getInterViewMergeCands(uiPUIdx, aiPdmRefIdx, acPdmMv, &cDisInfo, iPdmDir );
+  }  
+    
   Int iPdmInterDir;
-
   if( iPdmDir[0] && ivMvPredFlag )
   {

branches/HTM-DEV-0.3-dev2/source/Lib/TLibEncoder/TEncCavlc.cpp

@@ -741 +741 @@
     }
   }
-#if H_3D_GEN
+#if H_3D_GEN  
   WRITE_FLAG( 1,                                             "vps_extension2_flag" );
   for( Int layer = 0; layer <= pcVPS->getMaxLayers() - 1; layer++ )
@@ -754 +754 @@
       }          
     }        
-  }
+  }  
 #else
   WRITE_FLAG( 0,                                             "vps_extension2_flag" );

branches/HTM-DEV-0.3-dev2/source/Lib/TLibEncoder/TEncGOP.cpp

@@ -495 +495 @@
 
 #if H_3D_GEN
-    m_pcSliceEncoder->initEncSlice ( pcPic, iPOCLast, pocCurr, iNumPicRcvd, iGOPid, pcSlice, m_pcEncTop->getVPS(), m_pcEncTop->getSPS(), m_pcEncTop->getPPS() );     
+    m_pcSliceEncoder->initEncSlice ( pcPic, iPOCLast, pocCurr, iNumPicRcvd, iGOPid, pcSlice, m_pcEncTop->getVPS(), m_pcEncTop->getSPS(), m_pcEncTop->getPPS(), getLayerId() );     
 #else
     m_pcSliceEncoder->initEncSlice ( pcPic, iPOCLast, pocCurr, iNumPicRcvd, iGOPid, pcSlice, m_pcEncTop->getSPS(), m_pcEncTop->getPPS() );
@@ -504 +504 @@
     pcPic  ->setLayerId     ( getLayerId()   );
     pcPic  ->setViewId      ( getViewId()    );    
+#if !H_3D_GEN    
     pcSlice->setLayerId     ( getLayerId() );
     pcSlice->setViewId      ( getViewId()  );    
-#if !H_3D_GEN
     pcSlice->setVPS         ( m_pcEncTop->getVPS() );
 #endif
@@ -512 +512 @@
     pcPic  ->setViewIndex   ( getViewIndex() ); 
     pcPic  ->setIsDepth( getIsDepth() );
+#if !H_3D_GEN
     pcSlice->setViewIndex   ( getViewIndex()  );
     pcSlice->setIsDepth( getIsDepth() );    
+#endif
     pcSlice->setCamparaSlice( pcPic->getCodedScale(), pcPic->getCodedOffset() );    
 #endif

branches/HTM-DEV-0.3-dev2/source/Lib/TLibEncoder/TEncSlice.cpp

@@ -177 +177 @@
  */
 #if H_3D_GEN
-Void TEncSlice::initEncSlice( TComPic* pcPic, Int pocLast, Int pocCurr, Int iNumPicRcvd, Int iGOPid, TComSlice*& rpcSlice, TComVPS* pVPS, TComSPS* pSPS, TComPPS *pPPS )
+Void TEncSlice::initEncSlice( TComPic* pcPic, Int pocLast, Int pocCurr, Int iNumPicRcvd, Int iGOPid, TComSlice*& rpcSlice, TComVPS* pVPS, TComSPS* pSPS, TComPPS *pPPS, Int layerId )
 #else
 Void TEncSlice::initEncSlice( TComPic* pcPic, Int pocLast, Int pocCurr, Int iNumPicRcvd, Int iGOPid, TComSlice*& rpcSlice, TComSPS* pSPS, TComPPS *pPPS )
@@ -186 +186 @@
   
   rpcSlice = pcPic->getSlice(0);
-#if H_3D_GEN
+#if H_3D_GEN 
+  // GT: Should also be activated for MV-HEVC at some stage
   rpcSlice->setVPS( pVPS );
+  Int vpsLayerId = pVPS->getLayerIdInNuh( layerId ); 
+
+  rpcSlice->setLayerId     ( layerId );
+  rpcSlice->setViewId      ( pVPS->getViewId      ( vpsLayerId ) );    
+  rpcSlice->setViewIndex   ( pVPS->getViewIndex   ( vpsLayerId ) );
+  rpcSlice->setIsDepth     ( pVPS->getDepthId     ( vpsLayerId ) != 0 );    
 #endif
   rpcSlice->setSPS( pSPS );

branches/HTM-DEV-0.3-dev2/source/Lib/TLibEncoder/TEncSlice.h

@@ -118 +118 @@
 #if H_3D_GEN
   Void    initEncSlice        ( TComPic* pcPic, Int pocLast, Int pocCurr, Int iNumPicRcvd, 
-                                Int iGOPid, TComSlice*& rpcSlice, TComVPS* pVPS, TComSPS* pSPS, TComPPS *pPPS ); 
+                                Int iGOPid, TComSlice*& rpcSlice, TComVPS* pVPS, TComSPS* pSPS, TComPPS *pPPS, Int layerId ); 
 #else
   Void    initEncSlice        ( TComPic*  pcPic, Int pocLast, Int pocCurr, Int iNumPicRcvd,