Changeset 1244 in 3DVCSoftware

Timestamp:

2 Jun 2015, 04:45:46 (9 years ago)

Author:

sharpjp-htm

Message:

Fix uninitialized value in cDtParam.bUseIC (it happened on intra block), it affects coding results a little.
#define NH_3D_IC_FIX 1
The fixed bug is the reason why the base layer's result changes when ic is enabled.
Note: similar fix may be needed in Inter SDC (please see H_3D_INTER_SDC_FIX)

Location:

branches/HTM-14.1-update-dev2-Sharp/source/Lib

Files:

• TLibCommon/TComRdCost.cpp (modified) (1 diff)
• TLibCommon/TypeDef.h (modified) (1 diff)
• TLibEncoder/TEncSearch.cpp (modified) (1 diff)

branches/HTM-14.1-update-dev2-Sharp/source/Lib/TLibCommon/TComRdCost.cpp

@@ -602 +602 @@
 
   cDtParam.bitDepth   = bitDepth;
+#if NH_3D_IC_FIX
+  cDtParam.bUseIC       = false;
+#endif
+#if H_3D_INTER_SDC_FIX
+  cDtParam.bUseSDCMRSAD = false;
+#endif
 
   Dist dist = cDtParam.DistFunc( &cDtParam );

branches/HTM-14.1-update-dev2-Sharp/source/Lib/TLibCommon/TypeDef.h

@@ -85 +85 @@
                                               // SEC_IC_NEIGHBOR_CLIP_I0080    // Clipping of neighboring sample position, JCT3V-I0080
                                               // LGE_CHROMA_IC_J0050_J0034
+#define NH_3D_IC_FIX                      1   // Fix uninitialized value in cDtParam.bUseIC (it happened on intra block)
 #define NH_3D_FULL_PEL_DEPTH_MAP_MV_ACC   1   // Full Pel Interpolation for Depth, HHI_FULL_PEL_DEPTH_MAP_MV_ACC
 

branches/HTM-14.1-update-dev2-Sharp/source/Lib/TLibEncoder/TEncSearch.cpp

@@ -2894 +2894 @@
       const Bool bUseHadamard=pcCU->getCUTransquantBypass(0) == 0;
       m_pcRdCost->setDistParam(distParam, sps.getBitDepth(CHANNEL_TYPE_LUMA), piOrg, uiStride, piPred, uiStride, puRect.width, puRect.height, bUseHadamard);
+#if NH_3D_IC_FIX
+      distParam.bUseIC = false;
+#endif
+#if H_3D_INTER_SDC_FIX
+      distParam.bUseSDCMRSAD = false;
+#endif
       distParam.bApplyWeight = false;
       for( Int modeIdx = 0; modeIdx < numModesAvailable; modeIdx++ )