Changeset 852 in SHVCSoftware for branches/SHM-dev/source/Lib/TLibCommon

Timestamp:

5 Aug 2014, 01:37:56 (11 years ago)

Author:

qualcomm

Message:

Bug fix for R0164

Location:

branches/SHM-dev/source/Lib/TLibCommon

Files:

• TCom3DAsymLUT.cpp (modified) (8 diffs)
• TCom3DAsymLUT.h (modified) (2 diffs)
• TypeDef.h (modified) (1 diff)

branches/SHM-dev/source/Lib/TLibCommon/TCom3DAsymLUT.cpp

@@ -17 +17 @@
   m_pCuboid = NULL;
   m_nResQuanBit = 0;
-#if R0164_CGS_LUT_BUGFIX
+#if R0164_CGS_LUT_BUGFIX_CHECK
   m_pCuboidExplicit = NULL;
+  m_pCuboidFilled = NULL;
 #endif
 }
@@ -60 +61 @@
   xAllocate3DArray( m_pCuboid , m_nYSize , m_nUSize , m_nVSize );
 
-#if R0164_CGS_LUT_BUGFIX
+#if R0164_CGS_LUT_BUGFIX_CHECK
   xAllocate3DArray( m_pCuboidExplicit , m_nYSize , m_nUSize , m_nVSize );
+  xAllocate3DArray( m_pCuboidFilled   , m_nYSize , m_nUSize , m_nVSize );
 #endif
 }
@@ -68 +70 @@
 {
   xFree3DArray( m_pCuboid );
-#if R0164_CGS_LUT_BUGFIX
-  xFree3DArray( m_pCuboidExplicit  );
+#if R0164_CGS_LUT_BUGFIX_CHECK
+  xFree3DArray( m_pCuboidExplicit );
+  xFree3DArray( m_pCuboidFilled   );
 #endif
 }
@@ -345 +348 @@
 }
 
-#if R0164_CGS_LUT_BUGFIX
+#if R0164_CGS_LUT_BUGFIX_CHECK
 Void TCom3DAsymLUT::xInitCuboids( )
 {
@@ -356 +359 @@
       { 
         m_pCuboidExplicit[yIdx][uIdx][vIdx] = false;
+        m_pCuboidFilled[yIdx][uIdx][vIdx]   = false;
       }
     }
@@ -361 +365 @@
 }
 
-Void TCom3DAsymLUT::xCuboidsExplicitCheck( Int yIdx , Int uIdx , Int vIdx )
-{
-  if ( m_pCuboidExplicit[yIdx][uIdx][vIdx] == false )
+Void TCom3DAsymLUT::xCuboidsFilledCheck( Int yIdx , Int uIdx , Int vIdx )
+{
+  if ( m_pCuboidFilled[yIdx][uIdx][vIdx] == false )
   {
     if( yIdx > 0) 
-      assert ( m_pCuboidExplicit[yIdx-1][uIdx][vIdx] );
+      assert ( m_pCuboidFilled[yIdx-1][uIdx][vIdx] );
 
     for ( Int nVertexIdx=0 ; nVertexIdx<4 ; nVertexIdx++ )
       m_pCuboid[yIdx][uIdx][vIdx].P[nVertexIdx] = yIdx == 0 ? xGetCuboidVertexPredA( yIdx , uIdx , vIdx , nVertexIdx ): xGetCuboidVertexPredAll( yIdx , uIdx , vIdx , nVertexIdx );
 
-    m_pCuboidExplicit[yIdx][uIdx][vIdx] = true ;
-  }
-}
-
-
-Void TCom3DAsymLUT::xCuboidsExplicitCheck( Bool bDecode )
+    m_pCuboidFilled[yIdx][uIdx][vIdx] = true ;
+  }
+}
+
+
+Void TCom3DAsymLUT::xCuboidsFilledCheck( Bool bDecode )
 {
   Int ySize = 1 << ( getCurOctantDepth() + getCurYPartNumLog2() );
@@ -388 +392 @@
       { 
         if ( bDecode )
-          xCuboidsExplicitCheck( yIdx , uIdx , vIdx );
-
-        assert( m_pCuboidExplicit[yIdx][uIdx][vIdx] );
+          xCuboidsFilledCheck( yIdx , uIdx , vIdx );
+
+        assert( m_pCuboidFilled[yIdx][uIdx][vIdx] );
       }
     }
@@ -415 +419 @@
 #endif
 
-#endif
-
+#if R0164_CGS_LUT_BUGFIX_CHECK
+Void  TCom3DAsymLUT::display( Bool bFilled )
+{
+  Int ySize = 1 << ( getCurOctantDepth() + getCurYPartNumLog2() );
+  Int uSize = 1 << getCurOctantDepth();
+  Int vSize = 1 << getCurOctantDepth();
+  Int vIdx=0;
+
+  printf("\n");
+  printf("3DLut Explicit flag:\n");
+  for( Int uIdx = 0 ; uIdx < uSize ; uIdx++ )
+  {
+    for( Int yIdx = 0 ; yIdx < ySize ; yIdx++ )
+    {
+      printf("%d\t", m_pCuboidExplicit[yIdx][uIdx][vIdx] );
+    }
+    printf("\n");
+  }
+
+  printf("3DLut values (explicit):\n");
+  for( Int uIdx = 0 ; uIdx < uSize ; uIdx++ )
+  {
+    for( Int yIdx = 0 ; yIdx < ySize ; yIdx++ )
+    {
+      if ( m_pCuboidExplicit[yIdx][uIdx][vIdx] )  printf("%d\t", m_pCuboid[yIdx][uIdx][vIdx].P[0].Y );
+      else                                        printf("?\t", m_pCuboid[yIdx][uIdx][vIdx].P[0].Y );
+    }
+    printf("\n");
+  }
+
+  printf("3DLut values (all):\n");
+  for( Int uIdx = 0 ; uIdx < uSize ; uIdx++ )
+  {
+    for( Int yIdx = 0 ; yIdx < ySize ; yIdx++ )
+    {
+      if ( bFilled ) {
+        if ( m_pCuboidFilled[yIdx][uIdx][vIdx] )  printf("%d\t"  , m_pCuboid[yIdx][uIdx][vIdx].P[0].Y );
+        else                                      printf("unk\t" , m_pCuboid[yIdx][uIdx][vIdx].P[0].Y );
+      }
+      else
+        printf("%d\t"  , m_pCuboid[yIdx][uIdx][vIdx].P[0].Y );
+    }
+    printf("\n");
+  }
+
+}
+#endif
+
+#endif
+

branches/SHM-dev/source/Lib/TLibCommon/TCom3DAsymLUT.h

@@ -74 +74 @@
   SYUVP getCuboidVertexResTree( Int yIdx , Int uIdx , Int vIdx , Int nVertexIdx );
   Void  setCuboidVertexResTree( Int yIdx , Int uIdx , Int vIdx , Int nVertexIdx , Int deltaY , Int deltaU , Int deltaV );
-#if R0164_CGS_LUT_BUGFIX
+#if R0164_CGS_LUT_BUGFIX_CHECK
   Void  xInitCuboids( );
-  Void  xCuboidsExplicitCheck( Int yIdx , Int uIdx , Int vIdx );
-  Void  xCuboidsExplicitCheck( Bool bDecode );
-  Void  xSetExplicit( Int yIdx , Int uIdx , Int vIdx )  { m_pCuboidExplicit[yIdx][uIdx][vIdx] = true ;}
+  Void  xCuboidsFilledCheck( Int yIdx , Int uIdx , Int vIdx );
+  Void  xCuboidsFilledCheck( Bool bDecode );
+  Void  display( Bool bFilled=true );
+  Void  xSetExplicit( Int yIdx , Int uIdx , Int vIdx )  { m_pCuboidExplicit[yIdx][uIdx][vIdx] = true ; xSetFilled(yIdx,uIdx,vIdx); }
+  Void  xSetFilled( Int yIdx , Int uIdx , Int vIdx )    { m_pCuboidFilled[yIdx][uIdx][vIdx] = true ; }
 #endif
 
@@ -114 +116 @@
   Int   m_nAdaptCThresholdV;
 #endif
-#if R0164_CGS_LUT_BUGFIX
+#if R0164_CGS_LUT_BUGFIX_CHECK
   Bool  *** m_pCuboidExplicit;
+  Bool  *** m_pCuboidFilled;
 #endif
 

branches/SHM-dev/source/Lib/TLibCommon/TypeDef.h

@@ -103 +103 @@
 #define R0151_CGS_3D_ASYMLUT_IMPROVE     1      ///< JCTVC-R0151: Non-uniform chroma partitioning and improved LUT coefficient coding
 #define R0164_CGS_LUT_BUGFIX             1      ///< JCTVC-R0164: Bug fix with LUT syntax
+#define R0164_CGS_LUT_BUGFIX_CHECK       0      ///< JCTVC-R0164: Add traces explicitly/non-explicitly encoded vertices and check if 3DLUT is correctly filled
 #define R0179_CGS_SIZE_8x1x1             1      ///< JCTVC-R0179: allow CGS LUT size to be 8x1x1 as well 
 #define R0300_CGS_RES_COEFF_CODING       1      ///< JCTVC-R0300: improved residual coefficient coding for R0151