Changeset 1524 in SHVCSoftware

Timestamp:

3 Feb 2016, 23:00:44 (8 years ago)

Author:

seregin

Message:

fix target layer Id assignment, ticket #97

Location:

branches/SHM-dev/source

Files:

• App/TAppDecoder/TAppDecCfg.cpp (modified) (1 diff)
• App/TAppDecoder/TAppDecTop.cpp (modified) (9 diffs)
• App/TAppEncoder/TAppEncCfg.cpp (modified) (5 diffs)
• App/TAppEncoder/TAppEncCfg.h (modified) (2 diffs)
• App/TAppEncoder/TAppEncTop.cpp (modified) (3 diffs)
• Lib/TLibCommon/TComSlice.cpp (modified) (1 diff)
• Lib/TLibDecoder/TDecTop.cpp (modified) (4 diffs)
• Lib/TLibDecoder/TDecTop.h (modified) (2 diffs)

branches/SHM-dev/source/App/TAppDecoder/TAppDecCfg.cpp

@@ -170 +170 @@
   if( targetLayerId < 0 )
   {
-    targetLayerId = layerNum - 1;
+    targetLayerId = MAX_VPS_LAYER_IDX_PLUS1 - 1;
   }
 

branches/SHM-dev/source/App/TAppDecoder/TAppDecTop.cpp

@@ -91 +91 @@
   for(Int i = 0; i < MAX_VPS_LAYER_IDX_PLUS1; i++ )
 #else
-  for( Int i = 0; i <= m_tgtLayerId; i++ )
+  for( Int i = 0; i <= m_commonDecoderParams.getTargetLayerId(); i++ )
 #endif
   {
@@ -179 +179 @@
   for(UInt layer = 0; layer < MAX_VPS_LAYER_IDX_PLUS1; layer++)
 #else
-  for(UInt layer=0; layer<=m_tgtLayerId; layer++)
+  for(UInt layer=0; layer <= m_commonDecoderParams.getTargetLayerId(); layer++)
 #endif
   {
@@ -234 +234 @@
       read(nalu);
 
-#if SVC_EXTENSION
       // ignore any NAL units with nuh_layer_id == 63
       if( nalu.m_nuhLayerId == 63 )
@@ -241 +240 @@
         continue;
       }
-#endif
-
-      if( (m_iMaxTemporalLayer >= 0 && nalu.m_temporalId > m_iMaxTemporalLayer) || !isNaluWithinTargetDecLayerIdSet(&nalu)  ||
-#if CONFORMANCE_BITSTREAM_MODE
-        (nalu.m_nuhLayerId > m_commonDecoderParams.getTargetLayerId()) )
-#else
-        (nalu.m_nuhLayerId > m_tgtLayerId) )
-#endif
+
+      if( (m_iMaxTemporalLayer >= 0 && nalu.m_temporalId > m_iMaxTemporalLayer) || !isNaluWithinTargetDecLayerIdSet(&nalu) || nalu.m_nuhLayerId > m_commonDecoderParams.getTargetLayerId() )
       {
         bNewPicture = false;
@@ -422 +415 @@
   for(UInt layer = layerIdxmin; layer < MAX_VPS_LAYER_IDX_PLUS1; layer++)
 #else
-  for(UInt layer = layerIdxmin; layer <= m_tgtLayerId; layer++)
-#endif
-#else
-  for(UInt layer = 0; layer <= m_tgtLayerId; layer++)
+  for(UInt layer = layerIdxmin; layer <= m_commonDecoderParams.getTargetLayerId(); layer++)
+#endif
+#else
+  for(UInt layer = 0; layer <= m_commonDecoderParams.getTargetLayerId(); layer++)
 #endif
   {
@@ -583 +576 @@
   for(UInt layer = 0; layer < MAX_VPS_LAYER_IDX_PLUS1; layer++)
 #else
-  for(UInt layer = 0; layer <= m_tgtLayerId; layer++)
+  for(UInt layer = 0; layer <= m_commonDecoderParams.getTargetLayerId(); layer++)
 #endif
   {
@@ -612 +605 @@
   for(UInt layer = 0; layer < MAX_VPS_LAYER_IDX_PLUS1; layer++)
 #else
-  for(UInt layer = 0; layer <= m_tgtLayerId; layer++)
+  for(UInt layer = 0; layer <= m_commonDecoderParams.getTargetLayerId(); layer++)
 #endif
   {
@@ -646 +639 @@
   for(UInt layer = 0; layer < MAX_VPS_LAYER_IDX_PLUS1; layer++)
 #else
-  for(UInt layer = 0; layer <= m_tgtLayerId; layer++)
+  for(UInt layer = 0; layer <= m_commonDecoderParams.getTargetLayerId(); layer++)
 #endif
   {
@@ -665 +658 @@
 #if SVC_EXTENSION  
 #if CONFORMANCE_BITSTREAM_MODE
-    m_cTDecTop.setNumLayer( MAX_LAYERS );
-#else
-    m_cTDecTop.setNumLayer( m_tgtLayerId + 1 );
+    m_cTDecTop.setConfModeFlag( m_confModeFlag );
 #endif
     m_cTDecTop.setCommonDecoderParams( &m_commonDecoderParams );
-    m_cTDecTop.setConfModeFlag( m_confModeFlag );
   }
 #endif

branches/SHM-dev/source/App/TAppEncoder/TAppEncCfg.cpp

@@ -121 +121 @@
 #if SVC_EXTENSION
 TAppEncCfg::TAppEncCfg()
-#if AVC_BASE
-: m_nonHEVCBaseLayerFlag(false)
-#endif
-, m_maxTidRefPresentFlag(1)
+: m_maxTidRefPresentFlag(1)
 , m_defaultTargetOutputLayerIdc (-1)
 , m_numOutputLayerSets          (-1)
@@ -131 +128 @@
 , m_outputInternalColourSpace(false)
 , m_elRapSliceBEnabled(false)
+#if AVC_BASE
+, m_nonHEVCBaseLayerFlag(false)
+#endif
 {
   memset( m_apcLayerCfg, 0, sizeof(m_apcLayerCfg) );
@@ -3130 +3130 @@
     ii++;
   }
+#if AVC_BASE
   if( m_numLayers > 1 && m_numPTLInfo > 1 && !m_nonHEVCBaseLayerFlag )
+#else
+  if( m_numLayers > 1 && m_numPTLInfo > 1 )
+#endif
   {
     assert(m_profileList[0] <= Profile::MULTIVIEWMAIN);  //Profile IDC of PTL in VPS shall be one of single-layer profile IDCs
@@ -3506 +3510 @@
   m_numLayers = m_numLayers > MAX_LAYERS ? MAX_LAYERS : m_numLayers;
   
-  // it can be updated after AVC BL support will be added to the WD
+#if AVC_BASE
   if( m_nonHEVCBaseLayerFlag )
   {
@@ -3513 +3517 @@
     m_crossLayerAlignedIdrOnlyFlag = false;
   }
+#endif
 
   // verify layer configuration parameters

branches/SHM-dev/source/App/TAppEncoder/TAppEncCfg.h

@@ -118 +118 @@
   Int       m_numLayers;                                      ///< number of layers
   Int       m_scalabilityMask[MAX_VPS_NUM_SCALABILITY_TYPES]; ///< scalability_mask
-#if AVC_BASE
-  Bool      m_nonHEVCBaseLayerFlag;                           ///< non HEVC BL
-#endif
   Bool      m_maxTidRefPresentFlag; 
 
@@ -542 +539 @@
   Bool      m_altOutputLayerFlag;                             ///< Specifies the value of alt_output_laye_flag in VPS extension
   Bool      m_elRapSliceBEnabled;
+#if AVC_BASE
+  Bool      m_nonHEVCBaseLayerFlag;                           ///< non HEVC BL
+#endif
 #endif
 

branches/SHM-dev/source/App/TAppEncoder/TAppEncTop.cpp

@@ -249 +249 @@
     //1
     m_cTEncTop.setInterLayerWeightedPredFlag                      ( m_useInterLayerWeightedPred );
+#if AVC_BASE
     m_cTEncTop.setMFMEnabledFlag                                  ( layer == 0 ? false : ( m_nonHEVCBaseLayerFlag ? false : true ) && m_apcLayerCfg[layer]->getNumMotionPredRefLayers());
+#else
+    m_cTEncTop.setMFMEnabledFlag                                  ( layer == 0 ? false : m_apcLayerCfg[layer]->getNumMotionPredRefLayers());
+#endif
 
     // set layer ID
@@ -1059 +1063 @@
 #if AVC_BASE
   vps->setNonHEVCBaseLayerFlag( m_nonHEVCBaseLayerFlag );
-  if ( m_nonHEVCBaseLayerFlag )
-  {
-    vps->setBaseLayerInternalFlag (false);
-  }
-#else
-  vps->setAvcBaseLayerFlag(false);
+  if( m_nonHEVCBaseLayerFlag )
+  {
+    vps->setBaseLayerInternalFlag(false);
+  }
 #endif
   
@@ -1607 +1609 @@
     {
       list<AccessUnit>::iterator first_au = outputAccessUnits.begin();
+#if AVC_BASE
       if( m_nonHEVCBaseLayerFlag )
       {
         first_au++;
       }
+#endif
       AccessUnit::iterator it_sps;
       for (it_sps = first_au->begin(); it_sps != first_au->end(); it_sps++)

branches/SHM-dev/source/Lib/TLibCommon/TComSlice.cpp

@@ -1879 +1879 @@
   ::memset(m_outputLayerFlag, 0, sizeof(m_outputLayerFlag));
 
-  ::memset(m_directDependencyFlag, 0, sizeof(m_directDependencyFlag));
+  ::memset(m_directDependencyFlag, false, sizeof(m_directDependencyFlag));
   ::memset(m_numDirectRefLayers,   0, sizeof(m_numDirectRefLayers  ));
   ::memset(m_refLayerId,           0, sizeof(m_refLayerId          ));

branches/SHM-dev/source/Lib/TLibDecoder/TDecTop.cpp

@@ -2294 +2294 @@
 Void TDecTop::setRefLayerParams( const TComVPS* vps )
 {
-  for(UInt layerIdx = 0; layerIdx < m_numLayer; layerIdx++)
-  {
-    TDecTop *decTop = (TDecTop *)getLayerDec(vps->getLayerIdInNuh(layerIdx));
+#if CONFORMANCE_BITSTREAM_MODE
+  for(UInt layerIdx = 0; layerIdx < MAX_VPS_LAYER_IDX_PLUS1; layerIdx++)
+#else
+  for(UInt layerIdx = 0; layerIdx <= m_commonDecoderParams->getTargetLayerId(); layerIdx++)
+#endif
+  {
+    UInt layerId = vps->getLayerIdInNuh(layerIdx);
+    TDecTop *decTop = m_ppcTDecTop[layerId];
     decTop->setNumSamplePredRefLayers(0);
     decTop->setNumMotionPredRefLayers(0);
@@ -2305 +2310 @@
       if (vps->getDirectDependencyFlag(layerIdx, j))
       {
-        decTop->setRefLayerId(decTop->getNumDirectRefLayers(), vps->getLayerIdInNuh(layerIdx));
+        decTop->setRefLayerId(decTop->getNumDirectRefLayers(), layerId);
         decTop->setNumDirectRefLayers(decTop->getNumDirectRefLayers() + 1);
 
@@ -2320 +2325 @@
 Void TDecTop::checkValueOfTargetOutputLayerSetIdx(TComVPS *vps)
 {
-  CommonDecoderParams* params = this->getCommonDecoderParams();
+  CommonDecoderParams* params = m_commonDecoderParams;
 
   if( params->getValueCheckedFlag() )
@@ -2390 +2395 @@
 #endif
     Int layerSetIdx = vps->getOutputLayerSetIdx( params->getTargetOutputLayerSetIdx() );  // Index to the layer set
-#if !CONFORMANCE_BITSTREAM_MODE
-    assert( params->getTargetLayerId() == vps->getNumLayersInIdList( layerSetIdx ) - 1);
-#endif
     
     // Check if the targetdeclayerIdlist matches the output layer set

branches/SHM-dev/source/Lib/TLibDecoder/TDecTop.h

@@ -133 +133 @@
   static Bool             m_bFirstSliceInSequence;
   UInt                    m_layerId;      
-  UInt                    m_numLayer;
   TDecTop**               m_ppcTDecTop;
   UInt                    m_smallestLayerId;
@@ -226 +225 @@
   UInt      getLayerId                      ()                              { return m_layerId;                }
   Void      setLayerId                      (UInt layer)                    { m_layerId = layer;               }
-  UInt      getNumLayer                     ()                              { return m_numLayer;               }
-  Void      setNumLayer                     (UInt uiNum)                    { m_numLayer = uiNum;              }
   TComList<TComPic*>*  getListPic           ()                              { return &m_cListPic;              }
   Void      setLayerDec                     (TDecTop **p)                   { m_ppcTDecTop = p;                }