Changeset 1248 in SHVCSoftware for branches/SHM-dev

Timestamp:

14 Jul 2015, 00:33:29 (9 years ago)

Author:

seregin

Message:

port rev 4242

Location:

branches/SHM-dev/source/Lib

Files:

• TLibCommon/TComLoopFilter.cpp (modified) (1 diff)
• TLibEncoder/TEncCu.cpp (modified) (2 diffs)
• TLibEncoder/TEncSearch.cpp (modified) (11 diffs)

branches/SHM-dev/source/Lib/TLibCommon/TComLoopFilter.cpp

@@ -454 +454 @@
     else
     {
-      if (edgeDir == EDGE_HOR)
-      {
-        pcCUP = pcCUQ->getPUAbove(uiPartP, uiPartQ, !pCtu->getSlice()->getLFCrossSliceBoundaryFlag(), false, !m_bLFCrossTileBoundary);
-      }
       if (pcSlice->isInterB() || pcCUP->getSlice()->isInterB())
       {

branches/SHM-dev/source/Lib/TLibEncoder/TEncCu.cpp

@@ -1380 +1380 @@
           }
 
-          rpcTempCU->setSkipFlagSubParts( rpcTempCU->getQtRootCbf(0) == 0, 0, uhDepth );
           Int orgQP = rpcTempCU->getQP( 0 );
           xCheckDQP( rpcTempCU );
@@ -1443 +1442 @@
   DEBUG_STRING_NEW(sTest)
 
+  // prior to this, rpcTempCU will have just been reset using rpcTempCU->initEstData( uiDepth, iQP, bIsLosslessMode );
   UChar uhDepth = rpcTempCU->getDepth( 0 );
-
-  rpcTempCU->setDepthSubParts( uhDepth, 0 );
-
-  rpcTempCU->setSkipFlagSubParts( false, 0, uhDepth );
 
   rpcTempCU->setPartSizeSubParts  ( ePartSize,  0, uhDepth );

branches/SHM-dev/source/Lib/TLibEncoder/TEncSearch.cpp

@@ -2275 +2275 @@
 #endif
 
-      for( Int i=0; i < numModesForFullRD; i++ ) 
+      for( Int i=0; i < numModesForFullRD; i++ )
       {
         CandCostList[ i ] = MAX_DOUBLE;
@@ -2334 +2334 @@
       pcCU->getIntraDirPredictor( uiPartOffset, uiPreds, COMPONENT_Y, &iMode );
 #endif
-      const Int numCand = ( iMode >= 0 ) ? iMode : Int(NUM_MOST_PROBABLE_MODES);      
+      const Int numCand = ( iMode >= 0 ) ? iMode : Int(NUM_MOST_PROBABLE_MODES);
 
       for( Int j=0; j < numCand; j++)
@@ -4515 +4515 @@
   UInt        uiHeight     = pcCU->getHeight( 0 );
 
+  // The pcCU is not marked as skip-mode at this point, and its coeffs and arlCoeffs will all be 0.
+  // due to prior calls to TComDataCU::initEstData(  );
+
   //  No residual coding : SKIP mode
   if ( bSkipRes )
@@ -4582 +4585 @@
   }
 
+  // TODO: there should be a check on the CU depth (but see to-do below regarding this feature) eg:
+  // bHighPass = (bHighPass && pcCU->getDepth(0) <= pcCU->getSlice()->getPPS()->getMaxCuDQPDepth());
 #if SVC_EXTENSION
   qpMin =  bHighPass ? Clip3( -pcCU->getSlice()->getQpBDOffsetY(), MAX_QP, pcCU->getQP(0) - m_iMaxDeltaQP ) : pcCU->getQP( 0 );
@@ -4594 +4599 @@
   TComTURecurse tuLevel0(pcCU, 0);
 
-  for ( qp = qpMin; qp <= qpMax; qp++ )
+  for ( qp = qpMin; qp <= qpMax; qp++ ) // TODO: see the to-do below about this loop.
   {
     dCost = 0.;
     uiBits = 0;
     uiDistortion = 0;
+
+    // TODO: see the to-do below. eg:
+    //if (qpMin != qpMax)
+    //{
+    //  pcCU->setQPSubParts(qp, 0, pcCU->getDepth(0));
+    //  pcCU->setSkipFlagSubParts(false, 0, pcCU->getDepth(0));
+    //}
 
     m_pcRDGoOnSbacCoder->load( m_pppcRDSbacCoder[ pcCU->getDepth( 0 ) ][ CI_CURR_BEST ] );
@@ -4621 +4633 @@
     }
 
-    if ( dZeroCost < dCost )
+    const Bool bRootCbf=pcCU->getQtRootCbf(0)!=0;
+    if ( dZeroCost < dCost || !bRootCbf )
     {
       if ( dZeroCost < dCost )
@@ -4634 +4647 @@
       {
         const ComponentID component = ComponentID(ch);
-        const UInt componentShift   = pcCU->getPic()->getComponentScaleX(component) + pcCU->getPic()->getComponentScaleY(component);
         ::memset( pcCU->getCbf( component ) , 0, uiQPartNum * sizeof(UChar) );
-        ::memset( pcCU->getCoeff(component), 0, (uiWidth*uiHeight*sizeof(TCoeff))>>componentShift );
+        if (qpMin != qpMax) // If there is only one iteration, then these will already be 0.
+        {
+          const UInt componentShift   = pcCU->getPic()->getComponentScaleX(component) + pcCU->getPic()->getComponentScaleY(component);
+          ::memset( pcCU->getCoeff(component), 0, (uiWidth*uiHeight*sizeof(TCoeff))>>componentShift );
+#if ADAPTIVE_QP_SELECTION
+          ::memset( pcCU->getArlCoeff(component), 0, (uiWidth*uiHeight*sizeof(TCoeff))>>componentShift );
+#endif
+        }
         ::memset( pcCU->getCrossComponentPredictionAlpha(component), 0, ( uiQPartNum * sizeof(Char) ) );
       }
@@ -4706 +4725 @@
   if( qpMin != qpMax && qpBest != qpMax )
   {
+    // TODO: this code has never been used, the qp doesn't change the QP coded, and the following assert prevented this code running.
+    //        also, skip flag got stuck-on, as nothing cleared it. Recommend removing this.
     assert( 0 ); // check
     m_pcRDGoOnSbacCoder->load( m_pppcRDSbacCoder[ pcCU->getDepth( 0 ) ][ CI_TEMP_BEST ] );
@@ -4724 +4745 @@
       ::memcpy( pcCU->getCrossComponentPredictionAlpha(compID),  m_phQTTempCrossComponentPredictionAlpha[compID], uiQPartNum * sizeof( Char ) );
     }
+    // TODO: see to-do above. eg:
+    // pcCU->setSkipFlagSubParts(  (pcCU->getMergeFlag( 0 ) && pcCU->getPartitionSize( 0 ) == SIZE_2Nx2N && !pcCU->getQtRootCbf( 0 )), 0, pcCU->getDepth(0) );
   }
   pcYuvRec->addClip ( pcYuvPred, pcYuvResiBest, 0, uiWidth );
@@ -4741 +4764 @@
   pcCU->getTotalCost()       = dCostBest;
 
-  if ( pcCU->isSkipped(0) )
-  {
-    static const UInt cbfZero[MAX_NUM_COMPONENT]={0,0,0};
-    pcCU->setCbfSubParts( cbfZero, 0, pcCU->getDepth( 0 ) );
-  }
-
-  pcCU->setQPSubParts( qpBest, 0, pcCU->getDepth(0) );
+  if( qpMin != qpMax) // TODO: see to-do above
+  {
+    pcCU->setQPSubParts( qpBest, 0, pcCU->getDepth(0) );
+  }
 }
 
@@ -5475 +5495 @@
 
 
-Void TEncSearch::xSetResidualQTData( TComYuv* pcResi, Bool bSpatial, TComTU &rTu )
+Void TEncSearch::xSetResidualQTData( TComYuv* pcResi, Bool bSpatial, TComTU &rTu ) // TODO: turn this into two functions for bSpatial=true and false.
 {
   TComDataCU* pcCU=rTu.getCU();