Opened 11 years ago

Closed 11 years ago

#995 closed enhancement (fixed)

Removal of variable bPreviousPictureDecoded

Reported by: adarsh Owned by:
Priority: minor Milestone: HM-11.1
Component: HM Version: HM-9.2
Keywords: Cc: fbossen, ksuehring, davidf, jct-vc@…

Description

The variable bPreviousPictureDecoded in TAppDecTop.cpp is effectively not used for any purpose. The attached patch removes the variable and its occurrences.

Attachments (1)

remove_bPreviousPictureDecoded.patch​ (1.3 KB) - added by adarsh 11 years ago.
Patch to remove bPreviousPictureDecoded

Download all attachments as: .zip

Change History (4)

comment:1 Changed 11 years ago by DefaultCC Plugin

  • Cc fbossen ksuehring davidf jct-vc@… added

Changed 11 years ago by adarsh

Patch to remove bPreviousPictureDecoded

comment:2 Changed 11 years ago by ksuehring

I had seen that before based on a compiler code analysis. It seems there was some intention to use the variable, but it also seems the code is still working without it. Maybe one of the original authors might want to check this.

Last edited 11 years ago by ksuehring (previous) (diff)

comment:3 Changed 11 years ago by fbossen

  • Milestone set to HM-11.1
  • Resolution set to fixed
  • Status changed from new to closed

Fixed in r3526

Note: See TracTickets for help on using tickets.

This list contains all users that will be notified about changes made to this ticket.

These roles will be notified: Reporter, Owner, Subscriber, Participant

  • Adarsh Krishnan Ramasubramonian(Reporter)
  • David Flynn(Subscriber)
  • Frank Bossen(Subscriber, Participant)
  • jct-vc@…(Subscriber)
  • karl.sharman@…(Always)
  • Karsten Suehring(Subscriber, Participant, Always)