id summary reporter owner description type status priority milestone component version resolution keywords cc 1100 Calculation for PicWidthInCtbsY doesn't seem to match the spec jackh "In TComSampleAdaptiveOffset::create(), there are four lines which I believe correspond to equations 7-15 and 7-17 in the spec: {{{ m_iNumCuInWidth = m_iPicWidth / m_uiMaxCUWidth; m_iNumCuInWidth += ( m_iPicWidth % m_uiMaxCUWidth ) ? 1 : 0; m_iNumCuInHeight = m_iPicHeight / m_uiMaxCUHeight; m_iNumCuInHeight += ( m_iPicHeight % m_uiMaxCUHeight ) ? 1 : 0; }}} Spec: PicWidthInCtbsY = Ceil( pic_width_in_luma_samples ÷ CtbSizeY ) (7-15) PicHeightInCtbsY = Ceil( pic_height_in_luma_samples ÷ CtbSizeY ) (7-17) In order to match the spec, should these lines not read: {{{ m_iNumCuInWidth = m_iPicWidth / m_uiMaxCUHeight; m_iNumCuInWidth += ( m_iPicWidth % m_uiMaxCUHeight ) ? 1 : 0; m_iNumCuInHeight = m_iPicHeight / m_uiMaxCUHeight; m_iNumCuInHeight += ( m_iPicHeight % m_uiMaxCUHeight ) ? 1 : 0; }}} instead? Seems like the division should be by the same quantity for both equations. " defect closed minor HM-10.1 HM HM-10.0 invalid fbossen ksuehring davidf jct-vc@…