Encoder

Encoder was run with parameter --DisableInter4x4=0:

bin/TAppEncoderStatic -c cfg/encoder_randomaccess.cfg --FrameRate=30 --FramesToBeEncoded=300 --SourceHeight=480 --SourceWidth=832 --InputFile=orig/RaceHorses_832x480_30.yuv --IntraPeriod=32 --DisableInter4x4=0 --QP=39 --SEIpictureDigest=0 --BitstreamFile=test.hvc --ReconFile=enc.yuv

Decoder

The decoder crashes with a segmentation fault:

Thread [1] (Suspended: Signal 'SIGSEGV' received. Description: Segmentation fault.)

7 TComPic::getNumPartInCU() /home/wien/work/workspace-hevc-hm/HM5.0/source/Lib/TLibCommon/TComPic.h:115 0x0806356d 6 TComLoopFilter::xDeblockCU() /home/wien/work/workspace-hevc-hm/HM5.0/source/Lib/TLibCommon/TComLoopFilter.cpp:243 0x08095f4e 5 TComLoopFilter::loopFilterPic() /home/wien/work/workspace-hevc-hm/HM5.0/source/Lib/TLibCommon/TComLoopFilter.cpp:179 0x08095e33 4 TDecGop::decompressGop() /home/wien/work/workspace-hevc-hm/HM5.0/source/Lib/TLibDecoder/TDecGop.cpp:417 0x0806c243 3 TDecTop::executeDeblockAndAlf() /home/wien/work/workspace-hevc-hm/HM5.0/source/Lib/TLibDecoder/TDecTop.cpp:236 0x0805316c 2 TAppDecTop::decode() /home/wien/work/workspace-hevc-hm/HM5.0/source/App/TAppDecoder/TAppDecTop.cpp:148 0x0804ee79 1 main() /home/wien/work/workspace-hevc-hm/HM5.0/source/App/TAppDecoder/decmain.cpp:79 0x0804c56b

I suggest to remove the prediction mode MODE_SKIP which is not necessary anymore and which can lead to some misunderstanding in the code review. Only few lines have to be changed and this cleanup reduces the code of couple of lines. After this change, only 2 prediction modes exist: MODE_INTER and MODE_INTRA.

In the current HEVC specification(11/2019), some places (9.3.1 and 9.3.2.1) use TableStateIdxWpp, TableMpsValWpp, TableStatCoeffWpp, PredictorPaletteSizeWpp and PredictorPaletteEntriesWpp, but some places (9.3.2.4 and 9.3.2.5) use tableStateSync, tableMPSSync, tableStatCoeffSync, PredictorPaletteSizeWpp and PredictorPaletteEntriesWpp. Suggest to correct this inconsistency.