There is no constructor for DistParam class in TComRdCost.h. Currently, there is a reliance on setting all members to valid values outside this class before computing distortion.

For example, this can cause a problem with TComRdCost::getDistPart( Pel* piCur, Int iCurStride, Pel* piOrg, Int iOrgStride, UInt uiBlkWidth, UInt uiBlkHeight, DFunc eDFunc ) function. When this function is called with DF_SADS or DF_HADS variants for eDFunc (I don't think such a call is present in the current code though), the function would return meaningless results and sometimes can cause encoder crash due to memory violation. This is because a member of DistParam class (cDtParam.iStep) is not set. Setting this value to 1 would be reasonable here.

The recommendation is to create a constructor for DistParam class. Furthermore, some members (pCb*, pCr*) are never used and can probably be removed to avoid confusion.

This error is very trivial but a bit confusing. In TAppEncCfg::xCheckParameter(),

xConfirmPara( (m_iSourceWidth % (m_uiMaxCUWidth >> (m_uiMaxCUDepth-1)))!=0, "Frame width should be multiple of double size of minimum CU size"); xConfirmPara( (m_iSourceHeight % (m_uiMaxCUHeight >> (m_uiMaxCUDepth-1)))!=0, "Frame height should be multiple of double size of minimum CU size");

should be replaced with

xConfirmPara( (m_iSourceWidth % (m_uiMaxCUWidth >> (m_uiMaxCUDepth-1)))!=0, "Frame width should be multiple of minimum CU size"); xConfirmPara( (m_iSourceHeight % (m_uiMaxCUHeight >> (m_uiMaxCUDepth-1)))!=0, "Frame height should be multiple of minimum CU size");

The current TMuC codec core allows input image sizes of odd multiple of minimum CU size and the TMuC document also does.

In TEncSearch.cpp between line 1493 and 1494, as well as between line 7039 and 7040, the following three lines need to be added:

#if HHI_MRG

m_pcEntropyCoder->encodeMergeInfo( pcCU, 0, true );

#endif

This fixes the issue, that an incorrect bitrate is estimated for RD-decisions.

In TEncEntropy.cpp between line 382 and 383, the following needs to be added:

if ( pcCU->getSlice()->isIntra() ) {

return;

}

This avoids the encoding of unwanted merge flags.

In TEncEntropy.cpp between line 900 and 901, the following needs to be added:

if( bRD )

uiAbsPartIdx = 0;

This corrects a wrong determination of merge candidates during the estimation process.

All line numbers are valid for version 0.6.